Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchgit: set http.proxy globally for submodules #295240

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fetchgit: set http.proxy globally for submodules #295240

merged 1 commit into from
Mar 21, 2024

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Mar 12, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@linsui linsui requested a review from roberth March 12, 2024 07:35
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3663

doronbehar
doronbehar reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I wonder though how did you notice you need this? Perhaps it'd be nice to put an explanation in the commit message.

@linsui
Copy link
Contributor Author

linsui commented Mar 21, 2024

I noticed this when I cloning a repo with submodules behind a proxy. Only the main repo can be cloned and the submodule clone fails with network errors.

@linsui
fetchgit: set http.proxy globally for submodules
1ed37ac 
git config in the repo doesn't work for submodules
@doronbehar
Copy link
Contributor

Oh I see, makes sense.

@doronbehar doronbehar merged commit c2684b4 into NixOS:master Mar 21, 2024
19 checks passed
@linsui linsui deleted the gitproxy branch March 21, 2024 17:30
@linsui
Copy link
Contributor Author

linsui commented Mar 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@roberth roberth Awaiting requested review from roberth

Assignees
No one assigned
Labels
6.topic: fetch 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@linsui @nixos-discourse @doronbehar